This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Reordered Hamburger Menu with layout mentioned in #1893 #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -578,26 +569,14 @@ function hamburgerTemplateInit (location, e) { | |||
| CommonMenu.separatorMenuItem, | |||
| CommonMenu.importBookmarksMenuItem() | |||
| ] | |||
| }, { | |||
| label: locale.translation('bravery'), | |||
| submenu: [ | |||
There was a problem hiding this comment.
we should still prefer the Bravery menu.
CC @bradleyrichter which order would you like it in?
|
@bradleyrichter @bbondy . The original menu items have been added back in pending appropriate Order, and decision on Report an Issue and Submit Feedback. |
| @@ -368,6 +369,14 @@ class UrlBar extends ImmutableComponent { | |||
| action='#' | |||
| id='urlbar' | |||
| ref='urlbar'> | |||
| <Button iconClass={this.titleMode ? 'fa-star' : 'fa-star-o'} | |||
There was a problem hiding this comment.
Not sure I understand, why was bookmarks moved into the urlbar component? It seems unrelated to the rest of the changeset.
There was a problem hiding this comment.
It is, It should be on another branch, not sure how it slipped in. This change is to tackle the new bookmark design.
|
Sorry for the delay, thank you! Merging in! |
|
👍 |
This was referenced Aug 21, 2016
This was referenced Aug 23, 2016
This was referenced Aug 24, 2016
This was referenced Aug 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Original Issue #1893