Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update index-dev.html #348

Closed
wants to merge 2 commits into from
Closed

Update index-dev.html #348

wants to merge 2 commits into from

Conversation

bkardell
Copy link
Contributor

re: issue #329, async gone wrong? bundle depends on webpack-dev-server...

brave#329 bundle depends on webpack-dev-server...
@bkardell
Copy link
Contributor Author

hmm I'm getting npm test errors regardless of this change... something is weird.

@bkardell
Copy link
Contributor Author

Hmm ok... I looked all over, was unable to find anything related to this that seemed it could plausibly be causing the build failure I was getting here last night, so I just pulled and basically did a commit with no changes to cause it to retrigger and now it passes. Weird. I guess possible explanation is that something was amiss with the build itself, or there is a bad test, or the async nature makes the test conditions racey? I'm gonna leave this here and head to work for the day until someone comments further. If necessary I can try to squash the commits.

@diracdeltas
Copy link
Member

Yeah, some of our tests are flakey :(. Anyway this fixes the console errors for me, so I'll cherry-pick the fix. Thanks!

@bkardell
Copy link
Contributor Author

Thank you! ...annnd the build failed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants