[WIP] Add settings for new tab behaviour #3488

kingscott · 2016-08-27T19:06:39Z

Submitted a ticket for my issue if one did not already exist; didn't need to, there was one created.
Used Github auto-closing keywords in the commit message.
Ran git rebase -i to squash commits if needed.

Frontend tasks

Add drop-down selector to choose what the new tab will load

Logic tasks

Hook up drop-down to given options new tab page
Hook up drop-down to home page
Hook up down-down to user's search engine
Handle use case 1: user opens new tab via '+' in tab bar
Handle use case 2: user opens new tab via hamburger menu

Fixes #2106

…ick the new tab button

bbondy · 2016-09-03T03:53:27Z

Thanks @kingscott !

@cezaraugusto could you merge this into your newtab branch then close this pull request? Thanks. We want to merge this at the same time as your work.

kingscott · 2016-09-03T03:55:16Z

@bbondy Still need to fix the case where the user opens a new tab with the keyboard.

bbondy · 2016-09-05T01:03:59Z

OK @kingscott do you anticipate doing that soon or should we pull in the code and add it?

kingscott · 2016-09-05T02:29:00Z

Yes I do @bbondy. Was going to do my best to get it done this week. Should I send you (or someone else) a message on Slack based on status close to the end of this week?

bbondy · 2016-09-05T03:15:23Z

Cool thanks, either Slack or here is fine.

@diracdeltas

2. Re-block running insecure content when frame closed fix #3770 Auditors: @diracdeltas Test Plan: For re-block option: 1. Go to `https://mixed-script.badssl.com/` 2. Click urlIcon and click `Load Unsafe Scripts` 3. Background should be red 4. Click urlIcon and click `Stop Loading Unsafe Scripts` 5. Background should be grey For re-blocked on frame closed 1. Go to `https://mixed-script.badssl.com/` 2. Click urlIcon and click `Load Unsafe Scripts` 3. Background should be red 4. Close tab 5. Go to `https://mixed-script.badssl.com/` on new tab again 6. Background should be grey

@diracdeltas

… scope fix #3793 Auditors: @diracdeltas Test Plan: For regular frame: 1. Go to https://mixed-script.badssl.com 2. Click urlIcon and click Load Unsafe Scripts 3. Background should be red 4. Go to https://mixed-script.badssl.com by regular new tab 5. Background should be grey 6. Go to https://mixed-script.badssl.com by private new tab 7. Background should be grey For private frame: 1. Go to https://mixed-script.badssl.com by private tab 2. Click urlIcon and click Load Unsafe Scripts 3. Background should be red 4. Go to https://mixed-script.badssl.com by regular new tab 5. Background should be grey 6. Go to https://mixed-script.badssl.com by private new tab 7. Background should be grey

@diracdeltas

repeats of a location/tabId pair should result in a `revisitP=true` call to `synopsis.addPublisher` so the `visits` counter is not incremented. auditor: @diracdeltas

@mrose17

Fix #3828 Auditors: @mrose17 Test Plan: 1. manually edit reconcileStamp in ledger-state.json to be 0 2. start browser, wait 15 minutes 3. verify that a notification bar appears and clicking the button in the bar goes to the Payments panel

Re-block running insecure content

@diracdeltas

Auditors: @diracdeltas Test Plan: N/A

@bbondy

Auditors: @bbondy, @alexwykoff Test plan: 1. Select Malay from the language dropdown in about:preferences 2. Restart browser 3. Ensure language tokens are in Malay 4. Select English from the language dropdown in about:preferences 5. Restart browser 6. Ensure language can be reset to English

Add Malay (Malaysia) language

Harmonize publisher visits

Fix localization sorting

new dialog design for adding funds

@luixxiul

Auditors: @luixxiul

@alexwykoff

Auditors: @alexwykoff

@bbondy

auditors: @bbondy

…ick the new tab button

bsclifton · 2016-10-31T09:56:21Z

Original branch was deleted and the patches here are super out of date-

I cherry picked commits, manually resolved the items, and squashed the commits into a branch on my fork:
https://github.com/brave/browser-laptop/compare/master...bsclifton:newtab-preferences?expand=1

I'm going to close this PR and I'll take over the remaining work 😄

Scott King added 6 commits August 26, 2016 09:35

Add settings for new tab behaviour, handle this behaviour when you cl…

555f2fa

…ick the new tab button

Scaffolding for deafult search engine appearing as new tab

df392c3

Merge remote-tracking branch 'upstream/master' into newtab-settings

ae38bbd

Grab proper search engine information on new tab

aee4706

New tab can load default search engine

95508af

New tab can load default search engine

62f53f0

bbondy added this to the 1.0.0 milestone Aug 30, 2016

darkdh and others added 18 commits September 8, 2016 13:49

Update display message

138692c

Add functionality for new tab options

040d27b

Merge remote-tracking branch 'upstream/master' into newtab-settings

8a5c7f3

keep track of location/tabId pairs

a711c39

repeats of a location/tabId pair should result in a `revisitP=true` call to `synopsis.addPublisher` so the `visits` counter is not incremented. auditor: @diracdeltas

Disable feature in private mode

7aded75

Show notification 24hrs prior to reconcilation

855ddad

Fix #3828 Auditors: @mrose17 Test Plan: 1. manually edit reconcileStamp in ledger-state.json to be 0 2. start browser, wait 15 minutes 3. verify that a notification bar appears and clicking the button in the bar goes to the Payments panel

Merge pull request #3808 from darkdh/3770

cf48e14

Re-block running insecure content

Follow-up refactor of #3808

4f276b9

Auditors: @diracdeltas Test Plan: N/A

Merge pull request #3843 from brave/malay

762fb32

Add Malay (Malaysia) language

Merge branch 'master' into harmonize-publisher-visits

a7abc9b

Merge pull request #3852 from brave/harmonize-publisher-visits

4e66585

Harmonize publisher visits

Fix localization sorting

2a62f96

Merge pull request #3855 from Liunkae/patch-2

1e04812

Fix localization sorting

new dialog design for adding funds

062f260

Merge pull request #3803 from brave/add-funds-dialog

f9c05e3

new dialog design for adding funds

bbondy and others added 14 commits September 10, 2016 00:11

Update l10n

d6e76f6

Auditors: @luixxiul

Update version for 0.12.1

48efaf4

Auditors: @alexwykoff

update dashlane to 4.2.3

f6f9ac5

auditors: @bbondy

Abstraction of handling new tab settings

60727a5

Add settings for new tab behaviour, handle this behaviour when you cl…

07803f7

…ick the new tab button

Scaffolding for deafult search engine appearing as new tab

d08ebab

Grab proper search engine information on new tab

83cd9a7

New tab can load default search engine

36cf7c9

New tab can load default search engine

7cba675

Add functionality for new tab options

7c4ed74

Abstraction of handling new tab settings

1c7243d

Abstraction of handling new

2fa1b2e

Hopefully final abstraction to complete new tab functionality

b29251e

Hopefully final abstraction to complete new tab functionality

591202d

luixxiul added the settings label Oct 4, 2016

bsclifton closed this Oct 31, 2016

bsclifton removed this from the 1.0.0 milestone Oct 31, 2016

bsclifton mentioned this pull request Oct 31, 2016

General Settings: "A new tab shows" setting #2106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add settings for new tab behaviour #3488

[WIP] Add settings for new tab behaviour #3488

kingscott commented Aug 27, 2016 •

edited

Loading

bbondy commented Sep 3, 2016

kingscott commented Sep 3, 2016

bbondy commented Sep 5, 2016

kingscott commented Sep 5, 2016

bbondy commented Sep 5, 2016

bsclifton commented Oct 31, 2016

[WIP] Add settings for new tab behaviour #3488

[WIP] Add settings for new tab behaviour #3488

Conversation

kingscott commented Aug 27, 2016 • edited Loading

Frontend tasks

Logic tasks

bbondy commented Sep 3, 2016

kingscott commented Sep 3, 2016

bbondy commented Sep 5, 2016

kingscott commented Sep 5, 2016

bbondy commented Sep 5, 2016

bsclifton commented Oct 31, 2016

kingscott commented Aug 27, 2016 •

edited

Loading