This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Bookmark customTitle from previously bookmarked entry is no longer re-used #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,9 +109,6 @@ module.exports.addSite = function (sites, siteDetail, tag, originalSiteDetail) { | |||
| tags = tags.toSet().add(tag).toList() | |||
| } | |||
|
|
|||
| // We don't want bookmarks and other site info being renamed on users if they already exist | |||
| // The name should remain the same while it is bookmarked forever. | |||
| const customTitle = typeof siteDetail.get('customTitle') === 'string' ? siteDetail.get('customTitle') : (siteDetail.get('customTitle') || oldSite && oldSite.get('customTitle')) | |||
There was a problem hiding this comment.
did you check to make sure this isn't regressed? Use git blame on the task to see the original bug.
…-used when re-bookmarking. Fixes #3284 Auditors: @bbondy @luixxiul, @bradleyrichter Test Plan: - Visit a site which is not bookmarked - Bookmark the site- when the modal comes up, provide your own title "ABC" and hit enter - Notice bookmark is using customTitle - Delete bookmark - Re-add bookmark- this time don't change the title - Notice bookmark is now properly using title (not the old customTitle) Regression tests: - Drag bookmark into window frame. It should load and NOT update the bookmark custom title - Move the bookmark into and out of folders. Custom title should not be affected
|
Updated code after @bbondy left a comment (see above). The original commit I had done re-introduced an old bug. I reverted that and instead solved the issue by removing the custom title when bookmark is removed. Tests were added to reinforce this behavior 😄 |
|
excellent great fix, comment cleanup and tests! 👍 |
25 tasks
This was referenced Sep 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Bookmark customTitle from previously bookmarked entry is no longer re-used when re-bookmarking.
Fixes #3284
Auditors: @bbondy @luixxiul, @bradleyrichter
Test Plan: