This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
In payments status, show next contribution date #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -686,6 +686,21 @@ class PaymentsTab extends ImmutableComponent { | |||
| </div> | |||
| } | |||
|
|
|||
| get nextReconcileDate () { | |||
There was a problem hiding this comment.
this should return null if ledgerData.get('reconcileStamp') is not a number (may be undefined/null)
There was a problem hiding this comment.
i think I check for this on line 694 – is that right?
ayumi
force-pushed
the
feature/ledger-contribution-day-notice
branch
from
2883fe4
to
ba55077
Compare
| // Afterwards balance should always !== 0 due to exchange rate fluctuations. | ||
| const ledgerData = this.props.ledgerData | ||
| const balance = Number(ledgerData.get('balance') || 0) | ||
| if (balance === 0 || !ledgerData.get('reconcileStamp')) { |
There was a problem hiding this comment.
actually i think this should show up even if the balance is 0. there is sometimes a long delay between when the wallet is funded and when it actually shows up as balance.
ayumi
force-pushed
the
feature/ledger-contribution-day-notice
branch
from
ba55077
to
9f3e7b0
Compare
Fix #3801 Auditors: @bradleyrichter @diracdeltas Test Plan: 1. Open Brave to Preferences > Payments 2. Confirm the "status" column has "Next contribution: {date}" on the bottom
ayumi
force-pushed
the
feature/ledger-contribution-day-notice
branch
from
9f3e7b0
to
8e9684b
Compare
|
sweet thanks |
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #3801
Auditors: @bradleyrichter @diracdeltas
Test Plan:
First run
Created a wallet
Funded 💰