Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

If directly-entered URL load fails, show the location of the displayed page #3857

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

diracdeltas
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #3851
Add regression test for #2723

Auditors: @bridiver

Test Plan:
open bankofamerica.com in a tab
put http://bayden.com/test/redir/goscript.aspx in the urlbar and hit enter
verify that the URL bar still says bankofamerica.com

…d page

Fix #3851
Add regression test for #2723

Auditors: @bridiver

Test Plan:
open bankofamerica.com in a tab
put http://bayden.com/test/redir/goscript.aspx in the urlbar and hit enter
verify that the URL bar still says bankofamerica.com
@bbondy bbondy modified the milestones: 0.12.2dev, 0.12.1dev Sep 12, 2016
@bbondy
Copy link
Member

bbondy commented Sep 12, 2016

++

@luixxiul
Copy link
Contributor

luixxiul commented Sep 12, 2016

@diracdeltas pasting http://bayden.com/test/redir/goscript.aspx on the same tab after 1st try makes the url to it instead of bankofamerica.com, which is intended?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 12, 2016
@diracdeltas
Copy link
Member Author

@luixxiul that appears to be a bug

@luixxiul
Copy link
Contributor

I created follow-up: #3928

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Sep 12, 2016
diracdeltas added a commit that referenced this pull request Sep 13, 2016
Fix #3928
Fix #3927

Auditors: @bridiver

Test Plan:
Same as #3857 but also
make sure that entering a URL like nytimes.com in the URL bar does not
show a blank location before the page is done loading.
@diracdeltas diracdeltas deleted the fix/3851 branch September 22, 2016 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants