Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add backspace and shift-backspace for back/forward #424

Merged
merged 1 commit into from
Jan 30, 2016

Conversation

diracdeltas
Copy link
Member

This is somewhat flakey; pages can prevent us from triggering
the backspace listener. Not sure if it's worth merging now given
the complaints about page/local shortcuts overriding system
shortcuts on OS X.

Fix #192

This is somewhat flakey; pages can prevent us from triggering
the backspace listener.
@bbondy
Copy link
Member

bbondy commented Jan 30, 2016

given the complaints about page/local shortcuts overriding system
shortcuts on OS X.

Could you expand more on the types of problems you think would come up from this happening with Backspace?

@diracdeltas
Copy link
Member Author

Could you expand more on the types of problems you think would come up from this happening with Backspace?

I guess it's pretty unlikely that someone would override Backspace, but I'm wondering whether users have shortcuts mapped to Shift+Backspace that we would be overriding. see #351 (comment)

@diracdeltas
Copy link
Member Author

I'm about to fix #378 which will conflict with this, so merging for now. can revert later if there are complaints.

diracdeltas added a commit that referenced this pull request Jan 30, 2016
Add backspace and shift-backspace for back/forward
@diracdeltas diracdeltas merged commit 2e888a1 into master Jan 30, 2016
@diracdeltas diracdeltas deleted the fix/backspace-navigation branch February 4, 2016 00:56
@mikeal
Copy link

mikeal commented Oct 29, 2016

Is there a way to disable this?

@diracdeltas
Copy link
Member Author

@mikeal i honestly think we should just remove this shortcut; iirc chrome is doing so due to very low usage stats

@mikeal
Copy link

mikeal commented Nov 1, 2016

@diracdeltas I'm 100% for that. It's the first browser features I disable on a new install and I'm pretty sure it is a crazy IE relic.

@diracdeltas
Copy link
Member Author

sounds good. if people complain about it, we can add support for the official Google-maintained chrome extension. https://chrome.google.com/webstore/detail/go-back-with-backspace/eekailopagacbcdloonjhbiecobagjci

@diracdeltas
Copy link
Member Author

removed

@srirambv
Copy link
Collaborator

There has been two support tickets questioning the removal of backspace. Have provided workarounds for the users but there might be an increase in users asking to include this feature again

https://linkbubble.zendesk.com/agent/tickets/6661
https://linkbubble.zendesk.com/agent/tickets/6689

@diracdeltas Can we include the Chrome extension for 1.0 if start seeing an increase in support tickets on this?

@srirambv
Copy link
Collaborator

One more from support https://linkbubble.zendesk.com/agent/tickets/6692

@cndouglas
Copy link

+1 from #5781.

@ksjogo
Copy link

ksjogo commented Nov 22, 2016

How can I enable this again? The zendesk is not visible.

@bsclifton
Copy link
Member

@ksjogo we've kept this functionality removed... but when extensions are better supported, you'll be able to use the extension that @diracdeltas mentions here:
#424 (comment)

@lewellyn
Copy link

lewellyn commented Dec 12, 2016

As #6156 was closed, indirectly referencing this issue via #5781 and #5491, I'm here. So far this issue and #1302 (plus a UI problem I submitted via email which doesn't have an associated issue on Github that I can find so far) are keeping me from setting Brave as my default browser.

This is highly unfortunate, since this issue reads like only one platform has an issue with it so every platform has to lose it. And there's apparently some sort of workaround but it's not available to those of us who can't access those Zendesk tickets. 👎

@bsclifton
Copy link
Member

@lewellyn thanks for calling out the work-around being in the ticket system (private); here's the text for that:

As a workaround to navigate back using keyboard you can use Alt+Left arrow key to go back to the previous page and Atl+Right arrow key to go the next page

Since you feel strongly, let me re-open your issue and perhaps add some other acceptance criteria

@mikeal
Copy link

mikeal commented Dec 12, 2016

If this goes back in can it please be configurable because a lot of people hate it :)

@da0ist
Copy link

da0ist commented Mar 29, 2017

Backspace nor Alt+Left arrow (my usual method in browsers) doesn't work for me (ThinkPad X220/Ubuntu 16.04).

@luixxiul
Copy link
Contributor

@da0ist because backspace shortcut was removed. See: #5323. #6156 is the place where we discuss about getting it back as an option.

@bsclifton
Copy link
Member

bsclifton commented Mar 29, 2017

@da0ist alt + left/right arrow was unintentionally broken last release, we have a fix for that 😄 We're working on our next release now

@da0ist
Copy link

da0ist commented Mar 29, 2017 via email

@bsclifton
Copy link
Member

bsclifton commented Mar 29, 2017

@da0ist hang in there just a while longer! I'm hoping we'll have a release today or tomorrow 😄

If you have any more feedback, please feel free to let us know here or on community.brave.com 😄

@da0ist
Copy link

da0ist commented Mar 30, 2017 via email

@da0ist
Copy link

da0ist commented Mar 30, 2017 via email

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 30, 2017

@da0ist is #512 something that is related to your last request?

@da0ist
Copy link

da0ist commented Mar 30, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.