Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use png_data for favicon of bookmarks imported from HTML #4345

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 28, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4339

requires brave/muon#64

Auditors: @bridiver, @bbondy

Test Plan:

  1. Import bookmarks from HTML file
  2. There should be favicon shows when show favicon option is on

fix brave#4339

requires brave/muon#64

Auditors: @bridiver, @bbondy

Test Plan:
1. Import bookmarks from HTML file
2. There should be favicon shows when show favicon option is on
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Favicons doesnt work as expected
6 participants