Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave payments: Line should always appear when user scroll down #4395

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Sep 30, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #3888

Auditors @bsclifton @bradleyrichter

Test Plan:

Is this an idiomatic react approach for this? Also @bsclifton had a good point about it not being immediately obvious the table scrolls but I'm not sure how best to fix it. The only idea I had was to put focus on the table but that will mess with accessibility if people try to tab around.

Anyone have a good idea how to signal to the user that the table is scrollable?

@jkup jkup added this to the 0.12.4dev milestone Sep 30, 2016
@jkup jkup added the design A design change, especially one which needs input from the design team. label Sep 30, 2016
@bridiver
Copy link
Collaborator

bridiver commented Oct 4, 2016

@jkup when I run this branch the preferences tab is completely blank. I checked on master and it loads fine

@bridiver
Copy link
Collaborator

bridiver commented Oct 4, 2016

seems ok after a rebase

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave payments: Line should always appear when user scroll down
5 participants