This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Brave payments: Line should always appear when user scroll down #4395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fix #3888
Auditors @bsclifton @bradleyrichter
Test Plan:
Is this an idiomatic react approach for this? Also @bsclifton had a good point about it not being immediately obvious the table scrolls but I'm not sure how best to fix it. The only idea I had was to put focus on the table but that will mess with accessibility if people try to tab around.
Anyone have a good idea how to signal to the user that the table is scrollable?