Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

UrlbarSuggestions does not work if you are offline #4821

Merged
merged 1 commit into from
Oct 18, 2016
Merged

UrlbarSuggestions does not work if you are offline #4821

merged 1 commit into from
Oct 18, 2016

Conversation

Sh1d0w
Copy link

@Sh1d0w Sh1d0w commented Oct 15, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Fixes #3730

Auditors:
@bbondy

Test Plan:

  1. Make sure you turned on every type of suggestions you want to get via typing from the settings menu and set default Search Engine to duckduckgo
  2. Disconnect from internet
  3. Start typing something in the url bar

Fixes #3730

Auditors:
@bbondy

Test Plan:
1. Make sure you turned on every type of suggestions you want to get via typing from the settings menu and set default Search Engine to duckduckgo
2. Disconnect from internet
3. Start typing something in the url bar
@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

looks good, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants