Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add "Save Page As" to right click context menu #4831

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Add "Save Page As" to right click context menu #4831

merged 1 commit into from
Oct 17, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 16, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4830

Auditors: @bsclifton

Test Plan:

  1. right click on page
  2. context menu should contain "Save Page As"

@darkdh
Add "Save Page As" to right click context menu
a8290a0 
fix brave#4830

Auditors: @bsclifton

Test Plan:
1. right click on page
2. context menu should contain "Save Page As"
@darkdh darkdh added this to the 0.12.6dev milestone Oct 16, 2016
@bsclifton
Copy link
Member

LGTM 😄 ++

@bsclifton bsclifton merged commit d421e02 into brave:master Oct 17, 2016
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this pull request Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging this pull request may close these issues.

Right click context menu should have "Save Page As"
4 participants
@darkdh @bsclifton @alexwykoff @srirambv