This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix checked status on menu template (impacts Windows only) #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since titlebar was released with 0.12.3, the checked state has not updating properly because appState doesn't receive the update. Fixes #4810
bsclifton
commented
Oct 16, 2016
| appActions.changeSetting(settings.SHOW_BOOKMARKS_TOOLBAR, !isFirstBookmark || showBookmarksToolbar) | ||
| if (!hasOneBookmark && !getSetting(settings.SHOW_BOOKMARKS_TOOLBAR)) { | ||
| appActions.changeSetting(settings.SHOW_BOOKMARKS_TOOLBAR, true) | ||
| } | ||
| } |
There was a problem hiding this comment.
These changes were made to prevent appActions.changeSetting() from being called every time. Now it will only call if this is your first bookmark and toolbar is not already visible
bbondy
reviewed
Oct 17, 2016
| (site) => siteUtil.isBookmark(site) || siteUtil.isFolder(site) | ||
| ) | ||
| appActions.changeSetting(settings.SHOW_BOOKMARKS_TOOLBAR, !isFirstBookmark || showBookmarksToolbar) | ||
| if (!hasOneBookmark && !getSetting(settings.SHOW_BOOKMARKS_TOOLBAR)) { |
There was a problem hiding this comment.
It'd be cleaner to call this hasBookmarks since hasOneBookmark can be true when there are 2 bookmarks.
|
++ |
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Auditors: @bbondy
Since titlebar was released with 0.12.3, the checked state has not updating properly because appState doesn't receive the update.
Fixes #4810