Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"New bookmark folder" and "New bookmark" buttons added to about:bookmarks #4888

Merged
merged 1 commit into from
Oct 18, 2016
Merged

"New bookmark folder" and "New bookmark" buttons added to about:bookmarks #4888

merged 1 commit into from
Oct 18, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 18, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

"New bookmark folder" and "New bookmark" buttons added to about:bookmarks

  • sortableTable now allows you to provide a control instead of a string for the header
  • about:bookmarks now properly sets tableID (not used yet)
  • Adding a new bookmark now requires either a title or location (URL). Required because clicking new bookmark creates an empty object (versus existing buttons which always supply the current page).
  • Fixed style issue with about:bookmarks (moved border-right on folderView to organizeView

Fixes #4684
Fixes #4866

Auditors: @jkup, @bbondy

Test Plan

  1. Launch Brave and visit about:bookmarks
  2. Pick any folder on the left hand side and click it to select it
  3. Click the +folder icon, above the folder view
  4. Confirm that the new bookmark folder UI comes up and that it sets the parent folder properly
  5. Click add and ensure folder gets added
  6. Pick any folder and click it to select
  7. In the "title" column, hit the star+ icon to add a new bookmark
  8. Confirm you can't add an empty bookmark. Type and see the button enable itself. Delete chars and it disables itself again.
  9. Confirm the parent folder is correct and type in a title/url. When done, hit save.
  10. Confirm bookmark was added.

Screenshots

Two new buttons; folder with + and bookmark star with +
screen shot 2016-10-18 at 1 22 49 am

Example shot of clicking the add folder button
screen shot 2016-10-18 at 1 21 52 am

…arks

- sortableTable now allows you to provide a control instead of a string for the header
- about:bookmarks now properly sets tableID (not used yet)
- Adding a new bookmark now requires either a title or location (URL). Required because clicking new bookmark creates an empty object (versus existing buttons which always supply the current page).
- Fixed style issue with about:bookmarks (moved border-right on folderView to organizeView

Fixes #4684
Fixes #4866

Auditors: @jkup, @bbondy

Test Plan:
1. Launch Brave and visit about:bookmarks
2. Pick any folder on the left hand side and click it to select it
3. Click the +folder icon, above the folder view
4. Confirm that the new bookmark folder UI comes up and that it sets the parent folder properly
5. Click add and ensure folder gets added
6. Pick any folder and click it to select
7. In the "title" column, hit the star+ icon to add a new bookmark
8. Confirm you can't add an empty bookmark. Type and see the button enable itself. Delete chars and it disables itself again.
9. Confirm the parent folder is correct and type in a title/url. When done, hit save.
10. Confirm bookmark was added.
@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

Thanks, pls add an issue for adding tests for this and other missing things for bookmarks page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants