Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move bookmark hanger arrow now that reload is on about pages #4924

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Move bookmark hanger arrow now that reload is on about pages #4924

merged 1 commit into from
Oct 19, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 18, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4923

Auditors @bsclifton @darkdh

Test Plan:

Make sure the new bookmark UI's arrow on the top lines up with the star in all situations.

@jkup jkup added design A design change, especially one which needs input from the design team. feature/bookmarks labels Oct 18, 2016
@darkdh
Copy link
Member

darkdh commented Oct 18, 2016

looks good to me

@bbondy bbondy added this to the 0.12.6dev milestone Oct 19, 2016
@bbondy bbondy merged commit 72c1fbe into master Oct 19, 2016
@bsclifton
Copy link
Member

👍

@jkup jkup deleted the bookmark-hanger-arrow branch October 20, 2016 01:32
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this pull request Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging this pull request may close these issues.
5 participants
@jkup @darkdh @bsclifton @bbondy @alexwykoff