This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Import favicon fix: #4930
Merged
Import favicon fix: #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Iterate all urls using the favicon 2. Adjust made-up-favicon condition and override old made-up-favicon url fix brave#4882 Auditors: @bridiver, @bbondy Test Plan: 1. Import bookmarks from firefox on brave 0.12.3 2. Import bookmarks from firefox on brave contains this commit 3. The bookmarks under "Mozilla Firefox" should have favicons 1. Import bookmarks from any browsers 2. The imported bookmarks should have favicons 1. Import bookmarks from html bookmarks file 2. The imported bookmarks should have favicons
|
++ |
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #4882
Auditors: @bridiver, @bbondy
Test Plan: