Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add transition polishment for switch buttons #5013

Merged
merged 1 commit into from
Oct 24, 2016
Merged

add transition polishment for switch buttons #5013

merged 1 commit into from
Oct 24, 2016

Conversation

cezaraugusto
Copy link
Contributor

switchbtnanimatedtoggle

Auditors: @jkup

/cc @bradleyrichter

Test Plan:

  • enable/disable any switch button
  • notice that switch indicator moves smoothly

@jkup
Copy link
Contributor

jkup commented Oct 20, 2016

Code LGTM. Good to ship as long as @bradleyrichter approves the animation time (feels a bit slow to me!)

@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Oct 21, 2016
@bbondy
Copy link
Member

bbondy commented Oct 21, 2016

I think the animation time is a bit slow too

@bradleyrichter
Copy link
Contributor

Time should be barely noticeable.

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Oct 21, 2016

ok thanks all for the feedback. I'll reduce from 400ms to 200ms as it's the common number for most transitions we have.

@cezaraugusto
Copy link
Contributor Author

Updated to 100ms, ready for review

@bbondy
Copy link
Member

bbondy commented Oct 24, 2016

++

@bbondy bbondy merged commit 032dd8f into brave:master Oct 24, 2016
@bbondy
Copy link
Member

bbondy commented Oct 24, 2016

Please add an issue though and link it up in the commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
misc/button polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants