This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
add transition polishment for switch buttons #5013
Merged
bbondy
merged 1 commit into
brave:master
from
cezaraugusto:polish/switch-btn-transition
Oct 24, 2016
Merged
add transition polishment for switch buttons #5013
bbondy
merged 1 commit into
brave:master
from
cezaraugusto:polish/switch-btn-transition
Oct 24, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code LGTM. Good to ship as long as @bradleyrichter approves the animation time (feels a bit slow to me!) |
luixxiul
added
the
polish
Nice to have — usually related to front-end/visual tasks.
label
Oct 21, 2016
I think the animation time is a bit slow too |
Time should be barely noticeable. |
ok thanks all for the feedback. I'll reduce from 400ms to 200ms as it's the common number for most transitions we have. |
Updated to 100ms, ready for review |
++ |
Please add an issue though and link it up in the commit. |
This was referenced Oct 26, 2016
This was referenced Oct 27, 2016
This was referenced Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
misc/button
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-macOS
QA/checked-Win32
QA/checked-Win64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @jkup
/cc @bradleyrichter
Test Plan: