Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix multiple issues discovered by testers #5170

Merged
merged 4 commits into from
Oct 27, 2016
Merged

Fix multiple issues discovered by testers #5170

merged 4 commits into from
Oct 27, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix issue w/ secondary key on Windows (Mac appears to be unaffected)
Fixes #5165
Auditor: @darkdh

Windows - only apply border when NOT fullscreen (ex: in a YouTube video) and NOT maximized (Maximized or F11 fullscreen)
Fixes #5152
Auditor: @bbondy or @jonathansampson

Fix bold style causing element to resize issue on Bookmarks Manager for Windows.
(no issue)
Auditor: @srirambv

Order in which window position is read was updated (createWindow)
Fixes #3754
Auditors: @Sh1d0w

@darkdh
Copy link
Member

darkdh commented Oct 26, 2016

++ for 0567db2

Copy link
Collaborator

@jonathansampson jonathansampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I'd probably encourage a set of braces/explicit-return for the isForSecondaryAction block though. Nit-picky though :)

@Sh1d0w
Copy link

Sh1d0w commented Oct 27, 2016

@bsclifton Unfortunately the last window position still does not work. Maybe if I clear my history I can send you over my session-store-1 so you can reproduce? Ping me in slack so we can discuss this.

@bbondy
Copy link
Member

bbondy commented Oct 27, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants