This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fix multiple issues discovered by testers #5170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eo) and NOT maximized (Maximized or F11 fullscreen) Fixes #5152
++ for 0567db2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; I'd probably encourage a set of braces/explicit-return for the isForSecondaryAction
block though. Nit-picky though :)
@bsclifton Unfortunately the last window position still does not work. Maybe if I clear my history I can send you over my session-store-1 so you can reproduce? Ping me in slack so we can discuss this. |
++ |
This was referenced Oct 27, 2016
This was referenced Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fix issue w/ secondary key on Windows (Mac appears to be unaffected)
Fixes #5165
Auditor: @darkdh
Windows - only apply border when NOT fullscreen (ex: in a YouTube video) and NOT maximized (Maximized or F11 fullscreen)
Fixes #5152
Auditor: @bbondy or @jonathansampson
Fix bold style causing element to resize issue on Bookmarks Manager for Windows.
(no issue)
Auditor: @srirambv
Order in which window position is read was updated (createWindow)
Fixes #3754
Auditors: @Sh1d0w