Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

only set frame title when navigation is not renderer initiated #5211

Merged
merged 1 commit into from
Oct 29, 2016

Conversation

diracdeltas
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. go to http://web.mit.edu/zyan/Public/googlespoof.html
  2. click on the link
  3. when the new window stops loading, the tab title should be the tab URL instead of 'fake'

partial fix for #4973. this prevents the page-that-is-being-spoofed from displaying the title from the spoofing page.

requires brave/muon#83

auditors: @bbondy

partial fix for #4973. this prevents the page-that-is-being-spoofed from displaying the title from the spoofing page.

auditors: @bbondy
@diracdeltas diracdeltas added this to the 0.12.8dev milestone Oct 28, 2016
@bbondy
Copy link
Member

bbondy commented Oct 28, 2016

looks great but waiting for electron 1.4.21 to merge this.

@diracdeltas
Copy link
Member Author

merging now that electron has been updated on master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants