Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Properly handle a null row / zero rows #5237

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Properly handle a null row / zero rows #5237

merged 1 commit into from
Oct 28, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 28, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #5236

Auditors: @darkdh, @jkup

Test Plan:

  1. Launch Brave and go to Preferences
  2. Go to Search and confirm it loads
  3. Go to Payments and confirm it loads

Fixes #5236

Auditors: @darkdh

Test Plan:
1. Launch Brave and go to Preferences
2. Go to Search and confirm it loads
3. Go to Payments and confirm it loads
@bsclifton bsclifton added the bug label Oct 28, 2016
@bsclifton bsclifton added this to the 0.12.8dev milestone Oct 28, 2016
@jkup jkup merged commit e26ffd8 into brave:master Oct 28, 2016
@jkup
Copy link
Contributor

jkup commented Oct 28, 2016

++

1 similar comment
@darkdh
Copy link
Member

darkdh commented Oct 28, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants