Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix regression caused by removing drag from URL bar element #5240

Merged
merged 1 commit into from
Oct 29, 2016
Merged

Fix regression caused by removing drag from URL bar element #5240

merged 1 commit into from
Oct 29, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 28, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Fix regression caused by removing drag from URL bar element
Fixes #5225
Unfixes (breaks) #4922 (I manually reopened)

Auditors: @bbondy

Test Plan:

  1. Launch Brave and make the window smaller in size (800x600 for example)
  2. make sure you can drag the window by the top area (all 6 pixels for macOS)

Fixes #5225
Unfixes #4922

Auditors: @bbondy

Test Plan:
1. Launch Brave and make the window smaller in size (800x600 for example)
2. make sure you can drag the window by the top area (all 6 pixels for macOS)
@bbondy
Copy link
Member

bbondy commented Oct 29, 2016

nice, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: drag area above URL bar was reduced to 2px
5 participants