Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add custom title for imported bookmark #5263

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Add custom title for imported bookmark #5263

merged 1 commit into from
Oct 30, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 29, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #5060

Auditors: @bsclifton

Test Plan:

  1. Bookmark a page from other browser
  2. Rename the bookmark in step 1
  3. Import bookmakrs from the browser in step 1
  4. Click the bookmark and it shouldn't be renamed

fix brave#5060

Auditors: @bsclifton

Test Plan:
1. Bookmark a page from other browser
2. Rename the bookmark in step 1
3. Import bookmakrs from the browser in step 1
4. Click the bookmark and it shouldn't be renamed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmark titles getting renamed after import
4 participants