Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add transition for new-tabbackground #5330

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Add transition for new-tabbackground #5330

merged 1 commit into from
Nov 1, 2016

Conversation

cezaraugusto
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

to avoid flash of unstyled content

Auditors: @bsclifton

Closes #5309

Test Plan:

  • Enable new tab page
  • Open a new tab
  • There should be a smooth transition between the moment page is opened and background is charged

to avoid flash of unstyled content

Auditors: @bsclifton

Closes #5309

Test Plan:
* Enable new tab page
* Open a new tab
* There should be a smooth transition between the moment page is opened and background is charged
@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. feature/newtab labels Nov 1, 2016
@bsclifton
Copy link
Member

Looks great! Will merge here in a moment... @bradleyrichter: can you please get latest and try this out? Since the pictures need to load remotely, there was a noticeable delay which ended up causing a flash. This resolves that by gradually fading in (over 200ms)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/newtab polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants