Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL is normalized when updating favicon for a given site #5445

Merged
merged 1 commit into from
Nov 7, 2016
Merged

URL is normalized when updating favicon for a given site #5445

merged 1 commit into from
Nov 7, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

URL is normalized when updating favicon for a given site

Fixes #4860

Auditors: @cezaraugusto

Test Plan:

  1. if testing from source, make sure to run npm install to get new dependency
  2. Launch Brave and go to about:bookmarks
  3. Use the star+ icon to add a new bookmark and type "https://clifton.io" (no slash)
  4. Enable the bookmarks toolbar, if that makes it easier to see the bookmark icons.
  5. Notice there is no favicon yet
  6. Visit https://clifton.io/#testing123
  7. Notice the favicon is updated

Fixes #4860

Auditors: @cezaraugusto

Test Plan:
1. if testing from source, make sure to run `npm install` to get new dependency
2. Launch Brave and go to about:bookmarks
3. Use the star+ icon to add a new bookmark and type "https://clifton.io" (no slash)
4. Enable the bookmarks toolbar, if that makes it easier to see the bookmark icons.
5. Notice there is no favicon yet
6. Visit https://clifton.io/#testing123
7. Notice the favicon is updated
@cezaraugusto
Copy link
Contributor

++!!

@cezaraugusto cezaraugusto merged commit 4d54312 into brave:master Nov 7, 2016
@diracdeltas
Copy link
Member

the normalize-url package seems to be causing a crash for me. str:

  1. npm start
  2. visit bing.com
  3. open new tab, type 'bi' into the urlbar, wait for it to autocomplete to bing.com, hit enter. brave crashes with the error:
An uncaught exception occurred in the main process Uncaught Exception:
Error: Invalid URL
    at module.exports (/Users/yan/repos/browser-laptop/node_modules/normalize-url/index$
js:57:9)
   at sites.filter (/Users/yan/repos/browser-laptop/js/state/siteUtil.js:343:9)
...

@bsclifton bsclifton deleted the normalize-bookmark-url branch November 8, 2016 04:27
@bsclifton
Copy link
Member Author

bsclifton commented Nov 8, 2016

@diracdeltas disregard my prev comment (deleted)- I was able to repro. Looking into this...

@bsclifton
Copy link
Member Author

@diracdeltas fixed with c88726d

Sorry about that- definitely my bad. Thanks for reporting 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants