-
Notifications
You must be signed in to change notification settings - Fork 975
Create default topSites for new tab page #5623
Conversation
This needs to be rebased please |
@bradleyrichter did we decide on these top sites? |
If we are going with these I think we should cache these tile icons as well so we don't send requests to these places without a user visiting them. @bradleyrichter ? |
@bbondy and we could use larger favicons so the initial view is crispy... |
I think youtube is going to get more traffic than facebook but I will ask Catherine. |
Catherine suggested to swap Git for iOS app store, and this matches BE's opinion. |
Change looks good- only concern I have (@bbondy, @bradleyrichter) is this. We could show the default sites in two ways:
This PR is doing option 1... is that what we'd like? I personally would prefer option 2, but I'm curious what you all think 😄 Besides that, all that's left is the feedback from @bbondy; we can likely put a high res copy of the favicon into app/extensions/brave/img/. (I wouldn't say this is blocking- but a user did reach out to support, asking why does Brave make requests for these) Here's what it looks like right now; notice the default sites have a larger favicon size (64px x 64px): |
please change to #2. And when we have freceny done, the defaults will stay around longer and not be replaced even before a user sees them for the second time @garvankeeley may have comments related to his improvements over the same issues with iOS top sites. |
Still needs to load icons not remotely, moving this to 0.12.11 |
PR updated. @bbondy sites' icon are now stored within the app; |
* License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
* You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
const fs = require('fs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is never used, can you remove it pls? 😄
Fix #5594 Auditors: @bsclifton /cc @bradleyrichter Test Plan: * On a fresh (clean session-store) view, new tab should have a default grid with 6 sites, being them described on referenced issue * Visiting a new site should override previous grid * If session-store is previously populated, default topSites shouldn't appear on grid
@bsclifton thanks, updated |
Looks good to me 😄 |
git rebase -i
to squash commits (if needed).Fix #5594
Auditors: @bsclifton
@bradleyrichter:
Test Plan:
being them described on referenced issue
Note: Since we're having some issues with accessed sites, it may be required to refresh the new site in order for (2) to work