This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Stop about pages from being shown on topSites #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! 😄 I checked out, ran tests. @bbondy are we clear for merging for 0.12.11? |
|
UPDATE: sorry; I had reported this didn't work a few minutes ago, but I forgot... the top sites are only recalculated when you visit a new site. After navigating to a site, it removed the about page as expected! 😄 It seems before this change, about pages were showing it you bookmarked them (and this fixed that) 👍 |
darkdh
reviewed
Nov 20, 2016
| .windowParentByUrl(aboutNewTabUrl) | ||
| .waitForVisible(navigator) | ||
| .moveToObject(navigator) | ||
| .moveToObject(navigator) |
There was a problem hiding this comment.
Is this duplicate move to navigator intended?
There was a problem hiding this comment.
Nope, removed. Thanks @darkdh!
Auditors: @bsclifton, @luixxiul Fix #5638 Test Plan: * Go to any about page * Refresh it ~3x to make sure * About page shouldn't be on topSites grid * Bookmark the about page * Open a new tab * About page shouldn't be on topSites grid
This was referenced Dec 11, 2016
This was referenced Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Auditors: @bsclifton, @luixxiul
Fix #5638
Test Plan: