Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update findbar state onInput #5786

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Update findbar state onInput #5786

merged 1 commit into from
Dec 7, 2016

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Nov 22, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #5753

Test Plan:

  • Open a new Brave tab and navigate to any site.
  • Open the findbar (Find in Page: Ctrl/Cmd+F).
  • Copy some text from anywhere.
  • Right-click the findbar input.
  • Select Paste.
  • Make sure the highlighted matches and number of matches change accordingly.

Updates the state whenever the input field changes regardless of the reason.

Fixes #5753
@luixxiul
Copy link
Contributor

luixxiul commented Dec 7, 2016

Was this reviewed?

@bsclifton
Copy link
Member

@luixxiul not yet- did you want to check it out and give it a try? 😄

@cezaraugusto
Copy link
Contributor

elegant solution, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants