Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

First steps at getting the spectron/webdriver tests working #6006

Merged
merged 2 commits into from
Dec 5, 2016
Merged

First steps at getting the spectron/webdriver tests working #6006

merged 2 commits into from
Dec 5, 2016

Conversation

bsclifton
Copy link
Member

Tonite's progress. Brave crashes on shutdown which needs investigation

Feel free to merge (it's against chromium54) or keep it open as a WIP and I'll continue working on tests 😄

Auditors: @bridiver, @darkdh

@bsclifton bsclifton added this to the 0.13.0 milestone Dec 3, 2016
@darkdh
Copy link
Member

darkdh commented Dec 3, 2016

++ on c9f8030

@bsclifton
Copy link
Member Author

@bridiver per your comment #5995 (comment)

I updated the code in js/flash.js to use the methods in lib/urlutil.js. Take a peek at the PR and if that looks good, this should be ready for merge (into chromium54 branch) 😄

@bsclifton bsclifton merged commit b050724 into brave:chromium54 Dec 5, 2016
@bsclifton bsclifton deleted the chromium54-clifton branch December 5, 2016 06:15
@luixxiul
Copy link
Contributor

luixxiul commented Jan 18, 2017

Do we have an tracking issue for this? If not, please create one and add QA/no qa needed to it, thanks.

#5691

@bsclifton
Copy link
Member Author

@luixxiul #5691 is the closest to tracking there is (which you already shared). Marking as QA/no qa needed because these are automated tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants