This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Redo: Add copy to clipboard for about brave page (fixes #5790) #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6183 Redo PR #6107 (which was reverted with #6184) - cherry-picked 942e95c - Added brave.less for about:brave to fix regression on about pages TODO: Pick up properties from history.less into brave.less Auditors: @alexwykoff Test Plan: 1. Visit about:about
4 tasks
|
I was actually not sure to set property |
|
@luixxiul I can see the new less file possibly causing a regression in the future, but for now it's perfect Long term, we'll want to move toward Aphrodite components and defining the styles inline, in the component. If you have time, you may check out this new way of doing things here 😄 Notice the |
This was referenced Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR was closed #6186
This PR fixes #6183
Does not include changes to about:brave, because that was re-committed with 5324f3c
Auditors: @luixxiul
Test Plan:
#5790 #6107