This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update text for close tab section #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tabCloseActionParent=Parent tab | ||
| tabCloseActionLastActive=Select the last viewed tab | ||
| tabCloseActionNext=Select the next tab | ||
| tabCloseActionFirst=Select the first tab |
There was a problem hiding this comment.
"Select the first tab" should be removed.
cndouglas
reviewed
Feb 1, 2017
| tabCloseActionLastActive=Select the last viewed tab | ||
| tabCloseActionNext=Select the next tab | ||
| tabCloseActionFirst=Select the first tab | ||
| tabCloseActionParent=Select it's parent tab |
There was a problem hiding this comment.
"Select it's parent tab" should be "Select its parent tab".
NejcZdovc
force-pushed
the
hotfix/#6960-text-close-tab
branch
from
b805697
to
3703e56
Compare
|
@bradleyrichter @liunkae updated, please review it again |
cndouglas
changed the title
cndouglas
added
copy/content/text
PR/ready-for-merge
and removed
PR/needs-QA-attention ☕
labels
|
Actually, please squash the commits first. Then we'll be ready to merge. 😉 |
Resolves brave#6960 Auditors: @bradleyrichter Test Plan: - text's for close tab section should be the same as image attached to the original issue
NejcZdovc
force-pushed
the
hotfix/#6960-text-close-tab
branch
from
030e790
to
23374c4
Compare
|
@liunkae rebase done |
|
Most tests passed with CI; I re-ran each of the failed ones on my machine and they are passing. Merging! |
This was referenced Feb 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
text's for close tab section should be the same as image attached to the original issue
git rebase -ito squash commits (if needed).Resolves #6960
Auditors
@bradleyrichter