Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Focus active webview when closing downloads-bar #7038

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

michalbe
Copy link
Contributor

@michalbe michalbe commented Feb 3, 2017

Fixes #3219

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:
Webview now correctly gain focus after closing DownloadsBar (for instance up and down keys work, like on the attached gif).
focus-on-download

Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalbe! Works for me.

@michalbe
Copy link
Contributor Author

michalbe commented Feb 4, 2017

@liunkae thanks!

BTW, are failed CIs a normal thing in this project? Or it's just temporary?

@cndouglas
Copy link

@michalbe It is normal, unfortunately (#5389).

@bbondy
Copy link
Member

bbondy commented Feb 7, 2017

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants