Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Do not override themeColor if platform is Windows #7224

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Do not override themeColor if platform is Windows #7224

merged 1 commit into from
Feb 14, 2017

Conversation

cezaraugusto
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bbondy

Fix #7216

The main issue was that Windows specific style was being declared after themeColor and late declared classes take precedence so themeColor was being overridden on Windows.

Test plan:

  • Test it on Windows
  • Enable themeColor for tabs on settings
  • Go to https://facebook.com
  • Title color should be visible based on tab's background (getTextColorForBackground()) and not #555 (Windows specific color)

@cezaraugusto cezaraugusto added this to the 0.13.3 milestone Feb 13, 2017
@cezaraugusto cezaraugusto self-assigned this Feb 13, 2017
@bsclifton bsclifton self-requested a review February 13, 2017 22:31
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works great on Windows 😄 ++

@bbondy bbondy merged commit bcbafec into brave:master Feb 14, 2017
@cezaraugusto cezaraugusto deleted the feature/tabsbar/7216 branch July 25, 2017 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants