Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make Payments FAQ link obvious #7488

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Make Payments FAQ link obvious #7488

merged 1 commit into from
Mar 13, 2017

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Mar 4, 2017 •
edited by bsclifton
Loading

Test plan

  1. With a new session, launch Brave, open preferences, and go to Payments
  2. The FAQ link should be orange (per screenshot below) and very obviously be a link
  3. Click link, confirm it goes to FAQ

Description

Fixes #7487

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan: See issue #7487 for QA steps.

Screenshot:
image

@cndouglas cndouglas self-assigned this Mar 4, 2017
@bsclifton bsclifton added this to the 0.13.6 milestone Mar 13, 2017
@bsclifton bsclifton self-requested a review March 13, 2017 22:39
bsclifton
bsclifton approved these changes Mar 13, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 😄

@bsclifton bsclifton merged commit ba78b54 into brave:master Mar 13, 2017
@cndouglas cndouglas deleted the payments-FAQ branch March 14, 2017 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@cndouglas cndouglas

Labels
copy/content/text
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cndouglas @bsclifton @luixxiul