Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

show grey insecure icon for passive mixed content #7571

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 8, 2017

fix #2168

Auditors: @darkdh

Test Plan:

  1. automated tests related to lockIcon should pass
  2. go to mixed.badssl.com; the icon should be a grey unlocked icon
  3. clicking on the icon should tell you that the page is partially insecure
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #2168

Auditors: @darkdh

Test Plan:
1. automated tests related to lockIcon should pass
2. go to mixed.badssl.com; the icon should be a grey unlocked icon
3. clicking on the icon should tell you that the page is partially insecure
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh darkdh merged commit e2905d5 into master Mar 10, 2017
@bsclifton bsclifton added QA/test-plan-specified release-notes/include security design A design change, especially one which needs input from the design team. and removed PR/needs-QA-attention ☕ labels Mar 10, 2017
@diracdeltas diracdeltas deleted the feature/2168 branch March 26, 2017 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed UI for passive (display) mixed content
4 participants