Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improve flash hidden element detection #7752

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Improve flash hidden element detection #7752

merged 1 commit into from
Mar 17, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 16, 2017

Separates plugin content setting from flashEnabled setting so that shields down
allows tiny flash elements to be detected. Also improves hidden element detection
for slow/delayed element loads.

Fix #4020

Auditors: @srirambv @bbondy

Test Plan:

  1. go to reverso.net with flash enabled in about:preferences and shields down
  2. enter something in the box and click translate
  3. you should see a flash notification bar. click 'allow'
  4. click on the copy-paste icon in the results box. the page should tell you that the text was copied.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Separates plugin content setting from flashEnabled setting so that shields down
allows tiny flash elements to be detected. Also improves hidden element detection
for slow/delayed element loads.

Fix #4020

Auditors: @srirambv @bbondy

Test Plan:
1. go to reverso.net with flash enabled in about:preferences and shields down
2. enter something in the box and click translate
3. you should see a flash notification bar. click 'allow'
4. click on the copy-paste icon in the results box. the page should tell you that the text was copied.
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good; it'll try up to 3 times (1 second apart) to see if flash is on the page

Even though I felt like a horrible person installing Flash, I did install it and manually tested (code works great! 😄 )

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants