This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Handle sync network failure errors #8108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayumi
approved these changes
Apr 7, 2017
| get errorContent () { | ||
| return <div className='errorContainer'> | ||
| <div className='setupError'>{this.setupError}</div> | ||
| <button data-l10n-id='syncRetryButton' onClick={this.retry.bind(this)} /> |
There was a problem hiding this comment.
this looks like a little basic; what do you think of:
<Button l10nId='syncRetryButton' className='primaryButton' onClick={this.retry.bind(this)} />
less/about/preferences.less
Outdated
| color: red; | ||
| font-weight: bold; | ||
| } | ||
| .errorContainer { |
There was a problem hiding this comment.
if u do the Button change this can be removed
Fix #7972 Test plan: 1. turn off wifi 2. try to setup sync in a clean profile. you should see an error message. 3. turn wifi back on. 4. click the 'retry' button in about:preferences#sync 5. sync should now set up
diracdeltas
force-pushed
the
fix/sync-network-outage
branch
from
38f9e43
to
3f5bb7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7972
Test plan:
git rebase -ito squash commits (if needed).Test Plan: