Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adjusts layout of download items #8287

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Adjusts layout of download items #8287

merged 1 commit into from
Apr 13, 2017

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Apr 13, 2017 •
edited
Loading

Test Plan:

Click the trash bin on a download item
Note that the bottom alignment with other items isn't broken

PR Details:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8143

download-items

@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 13, 2017
@luixxiul
Copy link
Contributor

@jonathansampson would you mind adding margin below the border which appears when you click the trash bin icon?

@jonathansampson
Copy link
Collaborator Author

@luixxiul Please see the updated GIF and commit.

@luixxiul
Copy link
Contributor

LGTM!

@NejcZdovc NejcZdovc merged commit 2cb21dd into master Apr 13, 2017
@luixxiul luixxiul mentioned this pull request Apr 13, 2017
Closed
@bsclifton bsclifton deleted the downloads-bar-adjustments branch April 13, 2017 15:22
@bsclifton
Copy link
Member

++! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees
No one assigned
Labels
feature/download
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathansampson @luixxiul @bsclifton @NejcZdovc