Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move the FAQ link next to the payment on/off toggle #8337

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Move the FAQ link next to the payment on/off toggle #8337

merged 1 commit into from
Apr 17, 2017

Conversation

bsclifton
Copy link
Member

(instead of next to auto-include)

screen shot 2017-04-15 at 12 22 01 am

This is a suggestion, but I think it makes more sense here. See issue details for more info:
#7796

Fixes #7796

Auditors: @bradleyrichter, @luixxiul

Test Plan:

  1. Launch Brave and open Preferences > Payments
  2. You should see the "?" icon next to the on/off switch
  3. Toggle the on/off switch; it should still show after changing
  4. Click link and confirm it goes to Payment FAQ
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

…to auto-include)

This is a suggestion, but I think it makes more sense here. See issue details for more info:
#7796

Fixes #7796

Auditors: @bradleyrichter, @luixxiul

Test Plan:
1. Launch Brave and open Preferences > Payments
2. You should see the "?" icon next to the on/off switch
3. Toggle the on/off switch; it should still show after changing
4. Click link and confirm it goes to Payment FAQ
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradleyrichter
Copy link
Contributor

I think this was a bandaid. ; )

We should get Marketing to write the content and move it back.

@bsclifton bsclifton deleted the fix-payments-faq branch July 24, 2017 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants