Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable autoplay #8609

Merged
merged 2 commits into from
May 5, 2017
Merged

Disable autoplay #8609

merged 2 commits into from
May 5, 2017

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented May 1, 2017

Test plan

A.

  1. Go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
  2. Video should not autoplay
  3. Click bravey panel to allow autoplay
  4. Video should autoplay

B.

  1. Go to youtube and watch a video
  2. Video should not autoplay
  3. Click bravey panel to allow autoplay
  4. Video should autoplay

C. Also covered by automatic test


  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Resolves #7663
Resolves #2227
Resolves #4045

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a global default setting of autoplay preference.

@jonathansampson
Copy link
Collaborator Author

@darkdh You mean, a switch inside about:preferences#shields?

@darkdh
Copy link
Member

darkdh commented May 1, 2017

yeah, we should let users choose control the default global setting of it

@bridiver
Copy link
Collaborator

bridiver commented May 1, 2017

can we add tests for this? Preferably using a localhost url and not a remote site
otherwise ++

@jonathansampson
Copy link
Collaborator Author

@darkdh Global setting is now set.
@bridiver Working on test(s) next.

@jonathansampson
Copy link
Collaborator Author

@bridiver Spectron tests aren't running on Windows. I'm going to try and get it working on my Ubuntu VM, but it could be a day or two. Would you be okay with us merging prior to landing tests?

@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@darkdh
Copy link
Member

darkdh commented May 5, 2017

I can help adding the test from Mac

@darkdh darkdh self-assigned this May 5, 2017
@darkdh darkdh modified the milestones: 0.15.3, 0.15.4 May 5, 2017
@jonathansampson
Copy link
Collaborator Author

@darkdh That would be awesome! Thanks 🙂

@bsclifton bsclifton deleted the disable-autoplay branch May 22, 2017 16:39
@gary-schiltz
Copy link

I would also like to see the ability to control the preloading of HTML5 videos, since it consumes bandwidth, even if the user has no intention of watching a video. The desired behavior would be for the browser to act as if the preload attribute of all

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants