-
Notifications
You must be signed in to change notification settings - Fork 975
Conversation
794c34d
to
704e63b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a global default setting of autoplay preference.
@darkdh You mean, a switch inside about:preferences#shields? |
yeah, we should let users choose control the default global setting of it |
can we add tests for this? Preferably using a localhost url and not a remote site |
8f2c8da
to
5e8ff84
Compare
@bridiver Spectron tests aren't running on Windows. I'm going to try and get it working on my Ubuntu VM, but it could be a day or two. Would you be okay with us merging prior to landing tests? |
I can help adding the test from Mac |
@darkdh That would be awesome! Thanks 🙂 |
Auditors: @jonathansampson, @bridiver
I would also like to see the ability to control the preloading of HTML5 videos, since it consumes bandwidth, even if the user has no intention of watching a video. The desired behavior would be for the browser to act as if the preload attribute of all |
Test plan
A.
B.
C. Also covered by automatic test
git rebase -i
to squash commits (if needed).Test Plan:
Resolves #7663
Resolves #2227
Resolves #4045