Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add nested flash link check #8756

Merged
merged 1 commit into from
May 19, 2017
Merged

Add nested flash link check #8756

merged 1 commit into from
May 19, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented May 8, 2017

fix #8581

Auditors: @diracdeltas, @bbondy

Test Plan:
Covered by automatic test

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #8581

Auditors: @diracdeltas, @bbondy

Test Plan:
Covered by automatic test
@darkdh darkdh added this to the 0.15.4 milestone May 8, 2017
@darkdh darkdh self-assigned this May 8, 2017
@darkdh darkdh requested review from diracdeltas and bbondy May 8, 2017 07:20
@darkdh
Copy link
Member Author

darkdh commented May 8, 2017

@diracdeltas , there is still one problem with this PR. If I go to https://play.hbogo.com/ and click the flash link, preventDefault() doesn't constrain new tab from being spawned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to view HBOGO video
4 participants