Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactors addEditBookmarkHanger and addEditBookmark into redux #8928

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Refactors addEditBookmarkHanger and addEditBookmark into redux #8928

merged 1 commit into from
Jun 7, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 18, 2017 •
edited
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8927

Auditors: @bsclifton

Test Plan:

  • Test that creating a bookmark on the bookmarks toolbar with the star button works
  • Test that creating a bookmark on the bookmarks toolbar by dragging the un/lock icon works
  • Test that creating a bookmark folder on the bookmarks toolbar works
  • Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
  • Test that clicking a bookmark in the toolbar loads the bookmark.
  • Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.15.400 milestone May 18, 2017
@NejcZdovc NejcZdovc self-assigned this May 18, 2017
@NejcZdovc NejcZdovc mentioned this pull request May 18, 2017
Closed
51 tasks
luixxiul
luixxiul approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan (copied from Wiki) works.

@bsclifton bsclifton changed the title Refactors addEditBookmarHanger and addEditBookmark into redux Refactors addEditBookmarkHanger and addEditBookmark into redux May 21, 2017
@NejcZdovc NejcZdovc force-pushed the redux/bookmarkHanger branch 2 times, most recently from 29002c0 to fcf89f1 Compare June 7, 2017 00:27
@NejcZdovc
Refactors addEditBookmarHanger and addEditBookmark to redux
cd35e14 
Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page
@NejcZdovc NejcZdovc merged commit bc5af54 into brave:master Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luixxiul luixxiul luixxiul approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@NejcZdovc NejcZdovc

Labels
refactoring/redux-component
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @luixxiul