Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Avoid iterating all sites on every about page #9015

Merged
merged 1 commit into from
May 24, 2017
Merged

Conversation

ayumi
Copy link
Contributor

@ayumi ayumi commented May 23, 2017

Fix #9004

With 10K bookmarks, saves 350 ms every new tab!

Auditors: @bsclifton

Test Plan:

  1. Check that tests pass.
  2. Bookmark a page
  3. Make a bookmark folder
  4. Open Bookmarks manager and confirm bookmark page and folder.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix #9004

Auditors: @bsclifton

Test Plan:
0. Check that tests pass.
1. Bookmark a page
2. Make a bookmark folder
3. Open Bookmarks manager and confirm bookmark page and folder.
@ayumi ayumi requested review from bbondy and bsclifton May 23, 2017 18:51
@ayumi ayumi self-assigned this May 23, 2017
@ayumi ayumi added this to the 0.15.300 milestone May 23, 2017
@bbondy
Copy link
Member

bbondy commented May 24, 2017

nice find 💯

@bbondy bbondy merged commit 6a9a017 into master May 24, 2017
bbondy added a commit that referenced this pull request May 24, 2017
Avoid iterating all sites on every about page
bridiver pushed a commit that referenced this pull request May 24, 2017
Avoid iterating all sites on every about page
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++! 😄

@bsclifton bsclifton deleted the fix/slow-about-pages branch May 24, 2017 22:45
bridiver pushed a commit that referenced this pull request May 25, 2017
Avoid iterating all sites on every about page
bridiver pushed a commit that referenced this pull request May 25, 2017
Avoid iterating all sites on every about page
bridiver pushed a commit that referenced this pull request May 25, 2017
Avoid iterating all sites on every about page
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants