Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Increase urlbarForm input height to the equal value as 'urlbarFormHeight' #9282

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Increase urlbarForm input height to the equal value as 'urlbarFormHeight' #9282

merged 1 commit into from
Jun 15, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 6, 2017

Also:

  • Set white background to .urlbarForm inside navigator
  • Remove redundant specifications (the specified background is inherited to all of the elements inside .urlbarForm)
  • Remove duplicate variables

Fixes #4922
Addresses #9283

Auditors:

Test Plan:

  1. Make sure that clicking the area between the top and bottom edge of the URL bar selects the URL address

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Assigning @cezaraugusto & @bsclifton for review - it would be appreciated if one of you could check if the fix should work as expected on Windows.

@luixxiul luixxiul added this to the 0.18.x milestone Jun 6, 2017
@luixxiul luixxiul self-assigned this Jun 6, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 6, 2017

I know that making one tiny change on navigationBar.less (which is messy to be honest) could lead to visual regressions, while this case I think it would not.

I will start working on that file soon, after browserButton is mostly refactored.

@luixxiul luixxiul changed the title Increase urlbarForm input to the equal value as 'urlbarFormHeight' Increase urlbarForm input height to the equal value as 'urlbarFormHeight' Jun 6, 2017
…ght'

Also:
- Set white background to .urlbarForm inside navigator
- Remove redundant specifications (the specified background is inherited to all of the elements inside .urlbarForm)
- Remove duplicate variables

Fixes #4922
Addresses #9283

Auditors:

Test Plan:
1. Make sure that clicking the area between the top and bottom edge of the URL bar selects the URL address
@cezaraugusto cezaraugusto modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double click in addressbar maximizes/restores the window instead of selecting the address
2 participants