Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactors UrlBarIcon into redux #9415

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 13, 2017

Test Plan

  • type :g into url bar -> google icon is shown
  • when you open new tab search icon is loaded
  • when you load a site that has certificate, lock icon should be shown
  • when you load a http site, unlock icon should be shown

Description

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9340

Auditors: @bsclifton @bridiver

Reviewer Checklist:

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 👍

@bsclifton bsclifton merged commit fe38717 into brave:master Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants