This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Removes state from Window component #9658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
bridiver
suggested changes
Jul 10, 2017
app/renderer/components/window.js
Outdated
| } | ||
| }) | ||
| componentDidMount () { | ||
| appActions.windowReady(getCurrentWindowId()) |
There was a problem hiding this comment.
this can happen anytime after windowStore.state = newState and should probably go after generateTabs
Resovles brave#9453 Auditors: @bsclifton @bbondy @bridiver Test Plan:
bridiver
approved these changes
Jul 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resovles #9453
Auditors: @bsclifton @bbondy @bridiver
Test Plan:
Reviewer Checklist:
Tests