Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Set bookmark parent ID to 0 if parentFolderObjectId is empty #9968

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 11, 2017

fix brave/sync#107

Test Plan:
follow test plan in brave/sync#107

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.17.15 (Release Channel) milestone Jul 11, 2017
@diracdeltas diracdeltas self-assigned this Jul 11, 2017
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌅

@bsclifton bsclifton merged commit be93d99 into master Jul 12, 2017
@bsclifton bsclifton deleted the fix/sync-107 branch July 12, 2017 05:00
bsclifton added a commit that referenced this pull request Jul 12, 2017
Set bookmark parent ID to 0 if parentFolderObjectId is empty
bsclifton added a commit that referenced this pull request Jul 12, 2017
Set bookmark parent ID to 0 if parentFolderObjectId is empty
This was referenced Jul 12, 2017
bsclifton added a commit that referenced this pull request Jul 12, 2017
Set bookmark parent ID to 0 if parentFolderObjectId is empty
@SergeyZhukovsky
Copy link
Member

Looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to Parent bookmark folder on Android is not sycned to laptop or iOS device
5 participants