check for -2 directly because tabs sometimes have no index

brave · May 1, 2018 · 504da0e · 504da0e
1 parent 03759b9
commit 504da0e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc
@@ -2597,8 +2597,10 @@ v8::Local<v8::Value> WebContents::TabValue() {
 bool WebContents::IsTab() {
 #if BUILDFLAG(ENABLE_EXTENSIONS)
   auto tab_helper = extensions::TabHelper::FromWebContents(web_contents());
-  if (tab_helper)
-    return tab_helper->get_index() > TabStripModel::kNoTab;
+  if (tab_helper) {
+    // browserAction haack
+    return tab_helper->get_index() != -2;
+  }
 #endif
 
   return false;