Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

PR 503 followup #509

Merged
merged 2 commits into from
Feb 28, 2018
Merged

PR 503 followup #509

merged 2 commits into from
Feb 28, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 23, 2018

and a lint fix

@darkdh darkdh self-assigned this Feb 23, 2018
@darkdh darkdh requested a review from bridiver February 23, 2018 22:46
@darkdh darkdh requested a review from bsclifton February 26, 2018 23:15
bsclifton
bsclifton approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great- nice cleanup 😄 👍

@bsclifton bsclifton merged commit c04b58e into master Feb 28, 2018
@bsclifton bsclifton deleted the PR-503-followup branch February 28, 2018 20:27
bsclifton added a commit that referenced this pull request Feb 28, 2018
@bsclifton
Merge pull request #509 from brave/PR-503-followup
be1f2e9 
PR 503 followup
@bsclifton bsclifton added this to the 5.0.7 milestone Feb 28, 2018
darkdh added a commit that referenced this pull request Feb 28, 2018
@darkdh
Tor Browser Context
a7e7661 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
@darkdh darkdh mentioned this pull request Feb 28, 2018
Merged
bsclifton added a commit that referenced this pull request Mar 1, 2018
@bsclifton
Merge pull request #509 from brave/PR-503-followup
61c61d4 
PR 503 followup
bsclifton added a commit that referenced this pull request Mar 1, 2018
@bsclifton
DROPME - Merge pull request #509 from brave/PR-503-followup
d9484d7 
PR 503 followup
darkdh added a commit that referenced this pull request Mar 20, 2018
@darkdh
Tor Browser Context
5e85f53 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Mar 29, 2018
@darkdh
Tor Browser Context
18e065e 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Apr 3, 2018
@darkdh
Tor Browser Context
f31daf1 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Apr 4, 2018
@darkdh
Tor Browser Context
824e5a7 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Apr 25, 2018
@darkdh
Tor Browser Context
23207e7 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Apr 30, 2018
@darkdh
Tor Browser Context
8225401 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request May 9, 2018
@darkdh
Tor Browser Context
8ca8e53 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request May 15, 2018
@darkdh
Tor Browser Context
cb80536 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request May 18, 2018
@darkdh
Tor Browser Context
b7f36c5 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jun 11, 2018
@darkdh
Tor Browser Context
ed947f2 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jun 18, 2018
@darkdh
Tor Browser Context
8188a90 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jun 20, 2018
@darkdh
Tor Browser Context
807e7c7 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jun 21, 2018
@darkdh
Tor Browser Context
f12a822 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jun 27, 2018
@darkdh
Tor Browser Context
934b5d0 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jul 6, 2018
@darkdh
Tor Browser Context
3c49f14 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
darkdh added a commit that referenced this pull request Jul 25, 2018
@darkdh
Tor Browser Context
3623223 
1. context creating options: "isolated_storage", "tor_proxy"
2. setTorNewIdentity API
3. automatically launch tor when tor browser context created and tear it
down when tor browser context destroyed

fix #468
fix #464
fix #509
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@darkdh darkdh

Labels
branch-5.0.x merged/branch-5.0.x merged/master
Projects
None yet
Milestone
5.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @bsclifton