Add Importer support #57
Conversation
fix #2107 requires brave/muon#57 Auditors: @bridiver, @bbondy, @bsclifton
|
@darkdh looking through these changes to understand more... Looks like a LOT of this code is coming from Chromium, is that right? And after that, tweaks are made (functions added, edited, etc). Since there are so many files added, would you be able to give a medium level overview of what this PR adds/changes? Also, I'm curious what manual tests you've done and such Reading through quickly, I can see this adds support for importing from Chrome/FF/IE and more... including dialogs associated with these. Does this cover Chrome or FF sync import? |
|
We leverage the architecture of All the new added files are under
The manual tests I did are import history, bookmarks, cookies on chrome/firefox of different platforms, on Edge/IE of windows, on Safari of Mac. This PR doesn't cover Chrome/Firefox sync import but it does cover different profiles of chrome. |
bridiver
force-pushed
the
master
branch
2 times, most recently
from
59c0676
to
e6fed34
Compare
requires brave/libchromiumcontent#3 Auditors: @bridiver, @bbondy, @bsclifton
darkdh
force-pushed
the
import-browser-data
branch
from
a82e9a1
to
d7ec6be
Compare
| @@ -18,6 +18,7 @@ | |||
| 'lib/browser/api/dialog.js', | |||
| 'lib/browser/api/exports/electron.js', | |||
| 'lib/browser/api/global-shortcut.js', | |||
| 'lib/browser/api/importer.js', | |||
There was a problem hiding this comment.
can you move these to an importer.gypi file? See extensions.gypi
|
these never seem to want to close when I merge locally |
fix #2107 requires brave/muon#57 Auditors: @bridiver, @bbondy, @bsclifton
fix #2107 requires brave/muon#57 Auditors: @bridiver, @bbondy, @bsclifton
requires brave/libchromiumcontent#3
Auditors: @bridiver, @bbondy, @bsclifton