This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Use new site instance for SessionStorageNamespaceImpl clone when opener_suppressed(noopener) specified #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_suppressed(noopener) specified because WebContentsImpl::CreateNewWindow will use target_url as new site instance The problem was cloning original site instance cause the inconsistency between original partition and target partition because tor browser context enforce isolation storage so every different site has its own storage partition fix brave/browser-laptop#14392 Test Plan: 1. Open tor tab 2. Visit site contains rel="noopener" href (https://jsfiddle.net/dqokhmsg/) 3. Click the link 4. Brave shouldn't crash Auditors: @bridiver, @bbondy
darkdh
changed the title
bbondy
approved these changes
Jul 14, 2018
bridiver
approved these changes
Jul 18, 2018
darkdh
added a commit
that referenced
this pull request
Jul 18, 2018
Use new site instance for SessionStorageNamespaceImpl clone when opener_suppressed(noopener) specified
darkdh
added a commit
that referenced
this pull request
Jul 18, 2018
Use new site instance for SessionStorageNamespaceImpl clone when opener_suppressed(noopener) specified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because WebContentsImpl::CreateNewWindow will use target_url as new site instance
The problem was cloning original site instance cause the inconsistency
between original partition and target partition because tor browser
context enforce isolation storage so every different site has its own storage partition
fix brave/browser-laptop#14392
Test Plan:
Auditors: @bridiver, @bbondy