This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
Add /extensions endpoint #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
force-pushed
the
extensions
branch
3 times, most recently
from
7173202
to
8838740
Compare
|
@aekeus this is ready for review, pls also deploy if you are ok with the changes. |
aekeus
reviewed
Sep 26, 2016
|
|
||
| const setup = (runtime, availableExtensions) => { | ||
| let extensionsRoute = { | ||
| method: ['POST'], |
There was a problem hiding this comment.
Is a POST here a requirement of the extensions support? Generally a POST will mutate the state of the server.
There was a problem hiding this comment.
yes chrome uses POST so it's just implementing what they use.
aekeus
reviewed
Sep 26, 2016
| handler: function (request, reply) { | ||
| const requestedExtensions = getRequestedExtensions(request.payload.toString()) | ||
| const extensionsWithUpdates = getExtensionsWithUpdates(availableExtensions, requestedExtensions) | ||
| reply(getExtensionsResponse('https://s3.amazonaws.com/brave-extensions/release', extensionsWithUpdates)) |
There was a problem hiding this comment.
Perhaps we can we move this to an environment variable?
There was a problem hiding this comment.
I'll do env and default to that if not defined, good suggestion thx.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP while I get this integrated in desktop, it might need more changes. Just throwing it up for now though.